Skip to content

Update date references for 2026-05 triage (#2861)#2872

Merged
jyn514 merged 2 commits into
rust-lang:mainfrom
santihdzs:date-ref-triage-2026-05
May 29, 2026
Merged

Update date references for 2026-05 triage (#2861)#2872
jyn514 merged 2 commits into
rust-lang:mainfrom
santihdzs:date-ref-triage-2026-05

Conversation

@santihdzs
Copy link
Copy Markdown
Contributor

@santihdzs santihdzs commented May 15, 2026

Part of #2861.

Updated date references to May 2026 in:

  • src/contributing.md (×3)
  • src/implementing-new-features.md
  • src/normalization.md
  • src/rustdoc-internals.md
  • src/tests/minicore.md
  • src/tests/misc.md

Skipped lldb-visualizers.md and opaque-types-type-alias-impl-trait.md
as those reference external dependencies needing deeper verification.

r? rust-lang/rustc-dev-guide

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label May 15, 2026
@rustbot

This comment has been minimized.

@jyn514 jyn514 self-assigned this May 21, 2026
Copy link
Copy Markdown
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @santihdzs, did you generate this PR using an LLM? it's ok if you did, but please disclose beforehand that you did so.

View changes since this review

Comment thread src/tests/minicore.md Outdated
# `minicore` test auxiliary: using `core` stubs

<!-- date-check: Oct 2025 -->
<!-- date-check: May 2026 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any date here at all. Can we just remove the date-check comment?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any date here at all.

@jyn514 what does this mean

Comment thread src/tests/misc.md Outdated
## `RUSTC_BOOTSTRAP` and stability

<!-- date-check: Nov 2024 -->
<!-- date-check: May 2026 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, shouldn't be here

Comment thread src/contributing.md Outdated
Comment on lines +444 to +457
<!-- date-check --> Nov 2025
<!-- date-check --> May 2026
```

Example:

```md
As of <!-- date-check --> Nov 2025, the foo did the bar.
As of <!-- date-check --> May 2026, the foo did the bar.
```

For cases where the date should not be part of the visible rendered output,
use the following instead:

```md
<!-- date-check: Nov 2025 -->
<!-- date-check: May 2026 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in the contributing guide and not tied to anything specific. it doesn't need updating.

Comment thread src/implementing-new-features.md Outdated
@@ -1,4 +1,4 @@
<!-- date-check: Jul 2025 -->
<!-- date-check: May 2026 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, should just be removed.

Comment thread src/normalization.md Outdated
When interfacing with the type system it will often be the case that it's necessary to request a type be normalized. There are a number of different entry points to the underlying normalization logic and each entry point should only be used in specific parts of the compiler.

<!-- date-check: May 2025 -->
<!-- date-check: May 2026 -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, should just be removed

Comment thread src/rustdoc-internals.md
a lot of `rustdoc`'s architecture was designed around not doing that, but a
`TyCtxt` is now passed to `formats::renderer::run_format`, which is used to
run generation for both `HTML` and the (unstable as of <!-- date-check --> Nov 2025) JSON format.
run generation for both `HTML` and the (unstable as of <!-- date-check --> May 2026) JSON format.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this looks good

@rustbot rustbot added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels May 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 21, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@santihdzs
Copy link
Copy Markdown
Contributor Author

@jyn514 apologies for not disclosing upfront, I used an LLM as an aid but reviewed all changes myself before committing, I'll address the review comments now

@santihdzs santihdzs force-pushed the date-ref-triage-2026-05 branch from 56ee20f to 17dd4a7 Compare May 29, 2026 01:48
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 29, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 29, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@santihdzs
Copy link
Copy Markdown
Contributor Author

@jyn514 I addressed all review comments: reverted the contributing.md examples back to Nov 2025 and removed the date-check lines from the other files @rustbot ready

@rustbot rustbot added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content and removed S-waiting-on-author Status: this PR is waiting for additional action by the OP labels May 29, 2026
@jyn514 jyn514 merged commit fecdf8f into rust-lang:main May 29, 2026
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants